Remove squid proxy from backend operator#823
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRemoves the squid-proxy-based egress allowlist Helm template and legacy Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
==========================================
- Coverage 42.89% 42.83% -0.07%
==========================================
Files 203 203
Lines 26922 27121 +199
Branches 7614 7759 +145
==========================================
+ Hits 11548 11616 +68
- Misses 15262 15397 +135
+ Partials 112 108 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
deployments/charts/backend-operator/templates/backend-network-policy.yaml (1)
29-39: Consider IPv6 support for dual-stack clusters.The external egress rule only covers IPv4 (
0.0.0.0/0). In dual-stack Kubernetes clusters, external IPv6 traffic would be blocked by this policy.If dual-stack support is needed, add the IPv6 equivalent:
♻️ Proposed fix for dual-stack support
- to: - ipBlock: cidr: 0.0.0.0/0 {{- if .Values.global.networkPolicy.clusterCIDRs }} except: {{- range .Values.global.networkPolicy.clusterCIDRs }} - {{ . }} {{- end }} {{- end }} + - ipBlock: + cidr: ::/0 + {{- if .Values.global.networkPolicy.clusterCIDRs }} + except: + {{- range .Values.global.networkPolicy.clusterCIDRs }} + - {{ . }} + {{- end }} + {{- end }}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deployments/charts/backend-operator/templates/backend-network-policy.yaml` around lines 29 - 39, The network policy only allows IPv4 egress (ipBlock cidr: 0.0.0.0/0); add IPv6 dual-stack support by adding a second ipBlock with cidr: ::/0 and an accompanying except block sourced from a dedicated values key (e.g. .Values.global.networkPolicy.clusterCIDRsIPv6) to mirror the existing IPv4 except logic; update the template in backend-network-policy.yaml near the existing "ipBlock: cidr: 0.0.0.0/0" block to insert the ::/0 ipBlock and conditionally render its except entries exactly like the IPv4 block so IPv6 cluster-internal CIDRs are excluded when provided.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@deployments/charts/backend-operator/templates/backend-network-policy.yaml`:
- Around line 29-39: The network policy only allows IPv4 egress (ipBlock cidr:
0.0.0.0/0); add IPv6 dual-stack support by adding a second ipBlock with cidr:
::/0 and an accompanying except block sourced from a dedicated values key (e.g.
.Values.global.networkPolicy.clusterCIDRsIPv6) to mirror the existing IPv4
except logic; update the template in backend-network-policy.yaml near the
existing "ipBlock: cidr: 0.0.0.0/0" block to insert the ::/0 ipBlock and
conditionally render its except entries exactly like the IPv4 block so IPv6
cluster-internal CIDRs are excluded when provided.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5f8c1ed1-caa2-4cce-b76d-b17cca6fd68d
📒 Files selected for processing (3)
deployments/charts/backend-operator/templates/backend-egress-allowlist.yamldeployments/charts/backend-operator/templates/backend-network-policy.yamldeployments/charts/backend-operator/values.yaml
💤 Files with no reviewable changes (1)
- deployments/charts/backend-operator/templates/backend-egress-allowlist.yaml
cypres
previously approved these changes
Apr 9, 2026
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deployments/charts/backend-operator/README.md`:
- Line 53: Update the README wording to clarify that the NetworkPolicy’s
blocking of cross-namespace cluster traffic only occurs when cluster internal
CIDRs are configured: explicitly mention that NetworkPolicy (applied to
global.backendNamespace) allows unrestricted external egress but will block
cross-namespace cluster traffic only if global.networkPolicy.clusterCIDRs is set
(default [] means internal cluster egress may still match the 0.0.0.0/0 rule).
Also update the note referenced near the existing NetworkPolicy explanation to
warn readers that with global.networkPolicy.clusterCIDRs: [] the policy will not
exclude cluster-internal ranges and thus will not enforce cross-namespace
blocking.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b871e731-f2a4-4683-964e-4b5c7f12cef4
📒 Files selected for processing (1)
deployments/charts/backend-operator/README.md
|
📖 Docs preview: https://d3in15bfzp49i0.cloudfront.net/823/index.html |
elookpotts-nvidia
approved these changes
Apr 9, 2026
cypres
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove squid-proxy from backend-operator helm chart
Issue - None
Checklist
Summary by CodeRabbit